Rename Git auth function to explain it is not strictly related to GitHub#165
Merged
marco-c merged 2 commits intomozilla:masterfrom Jun 17, 2020
Merged
Rename Git auth function to explain it is not strictly related to GitHub#165marco-c merged 2 commits intomozilla:masterfrom
marco-c merged 2 commits intomozilla:masterfrom
Conversation
Luni-4
force-pushed
the
replace-github-auth
branch
from
e1fca82 to
873c966
Compare
marco-c
reviewed
Jun 17, 2020
marco-c
changed the title
marco-c
approved these changes
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
has_github_authhas been renamed tohas_git_auth. We need to change the token name in theymlfile also.Thanks in advance for your review! :)